Fix lint issues in ecs_logging/_stdlib.py - #172
Merged
Conversation
This commit addresses linting issues reported by `mypy` e.g. in https://github.com/elastic/ecs-logging-python/actions/runs/15781106393/job/44486719657?pr=171
v1v
approved these changes
Jun 25, 2025
xrmx
reviewed
Jun 25, 2025
| } | _LOGRECORD_DIR | ||
| converter = time.gmtime | ||
|
|
||
| convert = _converter |
Member
There was a problem hiding this comment.
@dliappis haven't you changed the name of this attribute?
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
Ugh turns out automerge kicked in. Will raise another PR.
Contributor
Author
dliappis
added a commit
to dliappis/ecs-logging-python
that referenced
this pull request
Jun 25, 2025
This commit fixes a typo observed in elastic#172 (comment)
dliappis
added a commit
to dliappis/ecs-logging-python
that referenced
this pull request
Jun 25, 2025
This commit fixes a mistake observed in elastic#172 (comment) With that identified, the code is now hopefully simpler.
dliappis
added a commit
to dliappis/ecs-logging-python
that referenced
this pull request
Jun 25, 2025
This commit fixes a mistake observed in elastic#172 (comment)
dliappis
added a commit
to dliappis/ecs-logging-python
that referenced
this pull request
Jun 25, 2025
This commit fixes a mistake observed in elastic#172 (comment) and allows to simply the code further (no need for a helper function)
xrmx
added a commit
that referenced
this pull request
Jun 26, 2025
* Fix typo identified in #172 This commit fixes a mistake observed in #172 (comment) and allows to simply the code further (no need for a helper function) * Add 3.8/3.9 compatibility for mypy * Fix lint * Also fix precommit and old mypy * Update ecs_logging/_stdlib.py * Update ecs_logging/_stdlib.py --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses linting issues reported by
mypye.g. in https://github.com/elastic/ecs-logging-python/actions/runs/15781106393/job/44486719657?pr=171